Expected: 401 Received: 200

Node
1

I’m doing the final exercise for Integration Testing. The first step is to test the PUT method for “should return 401 if client is not logged in” and I’m using the same code that Mosh provided but I keep getting this:

PUT_Error

Here’s my code:

// Test PUT Method

describe("PUT /:id", () => {
    let token;
    let newName;
    let genre;
    let id;
const exec = async () => {
  return await request(server)
      .put("/api/genres/" + id)
      .set("x-auth-token", token)
      .send({ name: newName });
 };
 beforeEach(async () => {
 // Before each test we need to create a genre and
 // put it in the database.
 genre = new Genre({ name: "genre1" });
     await genre.save();
     token = new User().generateAuthToken();
         id = genre._id;
         newName = "updatedName";
     });
  it("should return 401 if client is not logged in", async () => {
     token = "";
  const res = await exec();
  expect(res.status).toBe(401);
 });
});

Is anyone else experiencing this???

2

Normally 200 means status OK.

3

@William I agree, but that’s not helping my program pass the npm test.

4

First: I have not done this course so I am just guessing.

Are you sure you are not logged in? Return code 200 suggests you are logged in.

5

Okay so it turns out I was missing some code for DELETE and my PUT method was wrong.

For the PUT method, this is what Mosh was using:

router.put("/:id", async (req, res) => {
const { error } = validate(req.body);

if (error) return res.status(400).send(error.details[0].message);

const genre = await Genre.findByIdAndUpdate(
req.params.id,
{ name: req.body.name }, 
   { new: true, }
  );
   if (!genre)
 return res.status(404).send("The genre with the given ID was not found.");
 res.send(genre);

How ever a friend of mine who recently took the Node course was using this, and it worked!

 router.put("/:id", [auth, validateObjectId], async (req, res) => {
 const options = { new: true };
 const { error } = validate(req.body);
 if (error) return res.status(400).send(error.details[0].message);
    const genre = await Genre.findByIdAndUpdate(
req.params.id,
{ name: req.body.name },
options
);
if (!genre) return res.status(404).send("Genre not found");
res.status(200).send(genre);
});

And here’s my DELETE Method:

router.delete("/:id", [auth, admin, validateObjectId], async (req, res) => {
const genre = await Genre.findByIdAndRemove(req.params.id);
if (!genre)
return res.status(404).send("The genre with the given ID was not found.");
res.send(genre);
});
1 Like
6

I have a similar error

image
image834×342 14.1 KB

In the testcase for trying delete an invalid id, expected response is 404. But i get 500. Similarly the testcase for put also fails. Can you @pfabbi help me figure out!

it(‘return error for deleting invalid id’, async () => {

        id = 1;

        const response = await delete_genre();

        expect(response.status).toBe(404);

    });
7

Also having the same issue with testing DELETE/:id endpoint. Expecting 404, receiving 500.

error: Cannot read properties of undefined (reading ‘id’)

Not sure why the same test for the put/:id endpoint is working fine (essentially the same test, but using findByIdAndRemove(…) instead of findByIdAndUpdate(…))